[MERGE] #303568: tree lock is not released after a failing attempt at shelving an unversioned file

[Benoît PIERRE]

On 2009-03-02 19:27:33, Martin Pool wrote:
> Martin Pool has voted resubmit.
> Status is now: Resubmit
> Comment:
> I agree with John, it does seem like you need to defer this until the  
> iterator is run.
>
> The name 'finalize' seems to imply you can run it from a finally block  
> which would be cleaner than a bare except block.
>
> Is there maybe also a blackbox test for unshelve where you could add a  
> test for this case.

A "PathsNotVersionedError" exception can be raised during the
iterator setup. I added a test to test_shelf.py.

-- 
A: Because it destroys the flow of conversation.
Q: Why is top posting dumb?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shelve_release_lock.patch
Type: text/x-diff
Size: 6535 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090311/2a52c7d1/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090311/2a52c7d1/attachment.pgp