[Merge] Fix progress reporting in unshelve

Aaron Bentley aaron at aaronbentley.com
Mon Mar 9 04:30:12 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

This fixes the unshelve warnings we've been getting:

/home/abentley/bzr/bzr.dev/bzrlib/ui/text.py:99: UserWarning:
ProgressTask(0/3, msg='Merge phase') is not the top progress task
ProgressTask(None/None, msg='')
  (task, self._task_stack[-1]))

At the same time, it updates Merger.__init__ so that the default value
is None, and DummyProgress is used in that case.  This means that other
methods can pass in pb=None, which is more conventional, and it also
slightly reduces the overhead of creating a DummyProgress object as the
default argument.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkm0m1AACgkQ0F+nu1YWqI2wbQCggIxNqZVqITOWZ94mJ+NSBPud
APkAn1GpduSXIiU3C9CLAhf7NgvADRrB
=ujIu
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Aaron-s-mergeable-stuff-1950.patch
Type: text/x-patch
Size: 8477 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090309/26aa3979/attachment.bin 


More information about the bazaar mailing list