brisbane-core changes
John Arbash Meinel
john at arbash-meinel.com
Sat Mar 7 23:58:32 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hey Ian-
I'm happy to see work being done in the brisbane core branch, though I'm
pretty concerned about these changes:
3858 Ian Clatworthy 2009-03-07
don't check_remap on every unmap call in CHKMap.apply_delta()
3859 Ian Clatworthy 2009-03-07
only check for remap if changes are interesting in size
I think we want/need to make check_remap() cheaper, but it is the only
thing that ensures the tree stays in 'canonical' form. And I don't think
we can count that 50 bytes is the minimum size, or that 20 byte
reduction will/won't trigger a remap.
If this is just to reduce "deserialise" overhead, adding a cache of
deserialised pages or just making deserialise faster is probably a
better fix.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkmzCigACgkQJdeBCYSNAAPKVwCgtwYnlsDVqsbz3klesSXuDIWl
8o0AnjwbsgtUw97nnxa7tol8y3qBffho
=eojz
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list