[MERGE][#335180] LockableFiles.__del__ must die (was Re: Do you need to close a branch? (if so how))

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Hudson wrote:
> Robert Collins wrote:
>> Is the list with the value needed? 
>>
>> That gives LF->lock_value and LF->warner
>> and warner->lock_value
>> and warner has the __del__
>>
>> Looks to me like putting the lock value in the warner should work too
>> and would be a little less convoluted.
> 
> Yes, that would make more sense :)
> 
> Try the attached instead.
> 
> Cheers,
> mwh
> 

I'm a bit concerned, as there are some bits of code that inspect
"_lock_count" to check whether things are locked. We really should have
a simple api for that anyway, but the member was private, so code that
did that gets to handle fixing itself when we break it.

Anyway, I would just recommend adding a comment in NEWS, to make it
easier for people to realize why it broke, and how to fix the plugin.

BB:tweak

And if someone could else could merge this, as I'm offline for the next
couple of days.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmy8dkACgkQJdeBCYSNAAP//ACfbI37Tp4jrzbn88FjPgqci9Ej
9BoAoMeblDfmpg7HhPD+V6JNSbmiL2K9
=6Oez
-----END PGP SIGNATURE-----