[MERGE] Split up PushResult

[Jelmer Vernooij]

On Thu, 2009-03-05 at 22:32 -0500, Martin Pool wrote:
> Martin Pool has voted comment.
> Status is now: Semi-approved
> Comment:
> I wonder if it would be easier for hooks and others using the result if 
> it was a subclass rather than containing a branchpushresult?  Or would 
> that be conceptually wrong.
I think that would be conceptually wrong. It could also cause unexpected
exceptions in some cases as the "workingtree_updated" ivar is only set
by push(), not by Branch.push().

> In passing the way you handle report here makes me think it would be 
> nice for some commands to do their io by asking the UI to display the 
> result.  The result can then have a 'report' or a 'as plain text' 
> method, and the text ui could call that, but other UIs could do 
> something else.
Yeah, I agree that would make sense.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090307/e99b8ba2/attachment-0001.pgp