[patch][1.13 please] Ressurect progress bar for native Windows shell (bug #334808)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> https://bugs.launchpad.net/bugs/334808
> 
> New progress bar implemented by Martin Pool (in revno.3882.8.11)
> has very clearly visible regression on native Windows shell (not Cygwin):
> there is no progress bar at all.
> 
> This bug exists because of following (wrong) check in bzrlib/ui/__init__.py
> 
>     elif os.environ.get('TERM') in (None, 'dumb', ''):
>         # e.g. emacs compile window
>         cls = CLIUIFactory
> 
> Native Windows shell *never* has TERM environment variable.
> 
> BTW, old code that still exists in bzrlib/progress.py uses another check:
> 
>     if os.environ.get('TERM') == 'dumb':
>         # e.g. emacs compile window
>         return False
> 
> This patch removes None from bad TERM values, and fixes problem for me.
> It's trivial enough. Please merge it into 1.13.
> 

So I was a little hesitant, but I can see that the old code didn't check
for None either, so I'll go ahead and merge this.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmxinoACgkQJdeBCYSNAAOxNgCgvJqUrxjmiSKz98f5B0i4CqaZ
9xgAnjplhLEzXeQ/MJ9TpF+oxeDwOwRS
=MsOT
-----END PGP SIGNATURE-----