[MERGE] intern() various file_id/revision_id
John Arbash Meinel
john at arbash-meinel.com
Fri Mar 6 20:39:49 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Martin Pool wrote:
> Martin Pool has voted resubmit.
> Status is now: Resubmit
> Basically every time I've tried string interning in Python it's been a
> disappointment, even in cases where it would very likely have helped to
> do the equivalent in Java or Lisp. So I'm skeptical of merging this
> unless you have at least ad hoc measurements that it does help.
> I think you have to get a pretty high hit rate to overcome the
> apparently high overhead of interning them.
> I'm going to mark it resubmit to get it off my queue, but you can merge
> if you find it's useful.
> For details, see:
> Project: Bazaar
So at the least, I'm sure changing the one in xml8.py is worthy, as we
are already effectively doing an intern, only with a dictionary that
never expires. (intern() strings die when the last non-intern reference
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar