[brisbane-core/MERGE] inventory fix & refactor

John Arbash Meinel john at arbash-meinel.com
Wed Mar 4 15:34:38 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> 
> <snip/>
> 
>     jam> I may be one of the only/few that feel this way, so I'm
>     jam> happy to start a discussion on it.
> 
> I strongly feel that way too (I sent my email just before reading
> yours :), I'm happy to discuss the subject too.
> 
> May be fast-import is an exception that needs to maintain a
> mutable inventory while still being able to create CHKInventory
> objects as fast as possible, but even in that case, there should
> be a way to make that efficient without requiring CHKInventory to
> become mutable.
> 
>        Vincent
> 

fast-import should be trivially able to compute deltas from the import
stream, and then call 'new_inv = old_inv.create_by_apply_delta(delta)'.
Which is overall much better than trying to maintain an Inventory state.

Then again, I guess fast-import needs to do stuff like 'auto-remove
directories that no longer have child files/dirs', since it seems that
some systems don't track directories as first-class objects.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmun44ACgkQJdeBCYSNAAMFnACeNMxf7T5giWMTRpCNCfB1MsyO
3qkAn3IlJVSy68xrEJRqM2DzyBiaMBzb
=804E
-----END PGP SIGNATURE-----



More information about the bazaar mailing list