[MERGE][#335180] LockableFiles.__del__ must die (was Re: Do you need to close a branch? (if so how))

[Martin Pool]

2009/2/27 Michael Hudson <michael.hudson at canonical.com>:
> Michael Hudson wrote:
>
>> In fact, we seem to be accumulating socket._fileobjects in gc.garbage,
>> which would explain things...
>
> I still don't completely understand what's going on, but commenting out
> LockableFiles.__del__ makes this work.  One way of getting rid of this
> while still retaining the functionality is attached, it's a bit horrible
> though.

I agree that LockableFiles.__del__ (indeed most of that class) should
die.  However, note there is already CountedLock; please make sure
this is not redundant with that.

I think a name like LockWarner makes it less likely to seem redundant
or confusable.

-- 
Martin <http://launchpad.net/~mbp/>