Exception mangling in hooks?

[Robert Collins]

On Thu, 2009-02-26 at 08:31 -0600, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> ...
> 
> > [Plugins are entirely capable of
> > raising a nicely formated error themselves, as the pass-through of an
> > expected error type in the calling loop shows].
> > 
> > -Rob
> 
> History has shown that plugins do tend to be sloppy about error
> handling, and we have gotten a fair number of bug reports because of
> things that plugins do. (I don't have a count, but as an example just
> bzr-loom's handling of 'status' caused 3-4 repeat bugs to be raised in
> bzr core, even though the last line clearly showed it was occurring in
> bzr-loom.)

This is true, but loom was failing in command argument handling, not in
a hook. If the general principle were a good idea, we'd be wrapping
every exception that a plugin might generate, no?

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090227/f828dd55/attachment.pgp