[MERGE] Add BzrDir.open_repositoryV3

[Andrew Bennetts]

Andrew Bennetts has voted tweak.
Status is now: Conditionally approved
Comment:
Hmm, this diff includes Jelmer's InterBranch.  I assume that stuff is 
already approved, and that seeing it here is just an accident of the 
"bzr send" invocation...

> +        if response is None:
 > +            raise 
errors.UnknownSmartMethod('BzrDir.find_repository{3,2,}')

It would be ok to just use the last (and most primitive) verb 
(BzrDir.find_repository) as the arg here, really.  But it doesn't 
matter, it just looks a bit strange to my eyes to have that value not be 
a literal verb name.

As with some other the other new verbs, we ought to be using
“_remember_remote_is_before(...)” at appropriate points to avoid 
calling RPCs that we know old servers won't support.  Not worth blocking 
this for, though.


 > +        # There was an assertion that this real repository was never 
replaced;

How about replacing it with an assertion that it is never replaced with 
a different instance?  Setting the same instance seems harmless, but a 
different one would be a problem.

+        # However for down level serves we always open the real 
repository,

s/serves/servers/



For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C1235628158.24285.95.camel%40lifeless-64%3E
Project: Bazaar