[MERGE/RFC] Use Branch.pull() to update master branch.

Robert Collins robertc at robertcollins.net
Wed Feb 25 21:23:38 GMT 2009


On Wed, 2009-02-25 at 17:52 +0100, Jelmer Vernooij wrote:
> The attached patch makes the commit code use Branch.pull() to update the
> master branch when committing to a bound branch. 
> 
> This is required for bzr-svn as it can't update just the repository, it
> has to update the branch as well. Previously it had some magic in the
> Repository.fetch() code to handle this, but that is vulnerable to race
> conditions. (#248289)
> 
> Is Branch.pull() the right call here, or should I be adding something
> custom?

Pull is almost certainly not the right method. You're either pushing, or
perhaps just update_revisions.

The key question will be what hooks do you want to fire.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090226/cdc353b7/attachment.pgp 


More information about the bazaar mailing list