[MERGE] Add InterBranch.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> On Mon, 2009-02-23 at 14:09 -0500, John Arbash Meinel wrote:
>> John Arbash Meinel has voted resubmit.
>> Status is now: Resubmit
>> Comment:
>> The implementation seems okay, as it is just another InterObject code.
>>
>> However, this has no tests.
>>
>> Since it is going to be a point of implementations, we should probably 
>> add a "bzrlib.tests.per_interbranch" directory with a 
>> "test_update_revisions". You can probably crib most of that from one of 
>> the "bzrlib.tests.interX" test suites.
>>
> The attached version updates the patch with InterBranch tests.
> 
> Cheers,
> 
> Jelmer
> 

Since this is InterBranch, shouldn't you have a From and To format?

+class GenericInterBranch(InterBranch):
+    """InterBranch implementation that uses public Branch functions.
+    """
+
+    @staticmethod
+    def _get_branch_format_to_test():
+        return BranchFormat._default_format
+


^- So that this would then be:

def _get_branch_formats_to_test():
  return BranchFormat._default_format, BranchFormat._default_format


That way when you have your GitBranch optimizer it would return:

  return GitBranchFormat, BranchFormat._default_format

or something along those lines.



Are the "transport_server" and "transport_readonly_server" really necessary?

Otherwise it seems fine.

BB:tweak

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmlsgUACgkQJdeBCYSNAAOKZACeMpxbWyoyrhWe5wsm72+vXhDC
RoIAniDAGaUaOYQrdFFeeEfDIiYZZ0Cr
=9Xt6
-----END PGP SIGNATURE-----