[MERGE] Add helper class versionedfile.VersionedFilesDecorator for use with RemoteRepository in future.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


...

>> def __init__(self):
>>   VFD.__init__(self, hook_call=self._rvf_hook_call)
>>
>> Or some permutation on that.
>>
>> I realize what you do *works*, but only as long as you don't call
>> super().__init__, which doesn't seem like a good policy to require. At a
>> minimum it needs to be documented in __init__. I would prefer if you
>> passed the hook_call parameter.
> 
> I don't understand this; certainly in bzr we don't use super() anymore
> anyhow, but even if we did, what I did works, doesn't it?
> 
> -Rob

What you did works only because you don't initialize the base class.
Which at least seems like something which should be documented.

Personally it seems better to just use the API you defined. Namely, pass
a function to the base class for 'hook_call'.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmlUM4ACgkQJdeBCYSNAAO0JwCfal4lq8rNUXEps8TyaaRj460+
a48AoIHzkUtn4OEkNB7SsUOdcUCl8BBy
=sul6
-----END PGP SIGNATURE-----