test_source harmful?

[Robert Collins]

On Wed, 2009-02-25 at 16:35 +1100, Ben Finney wrote:
> Robert Collins <robert.collins at canonical.com> writes:
> 
> > The whitespace checks are really frustrating me;
> 
> I thought that was the point: to put the pain of fixing whitespace
> mistakes squarely where they belong, at the point of the person
> attempting to introduce them.

I don't think frustrating people was the point; honestly we 'never' (or
extremely rarely) had merge conflicts due to whitespace fixes being
done. Creating pain to solve a non-problem is hard for me to understand.

I don't think we can expect other projects to use a source code check
like we have done by default. If whitespace conflicts are such an issue
we should make our merge handle whitespace conflicts better - because
thats what our users will need.

> > I don't think we suffered anywhere near as much when occasional
> > trailing whitespace existed as we do when merges are rejected [after
> > a long test process]
> 
> Perhaps the checks on source should be done before running any tests
> of functionality. Is that sequencing possible?

It is, but it still means a round trip [context switching etc].

> > solely because
> > 
> > def foo(self): 
> >     """This is a docstring."""
> > 
> > I'd like to delete the test for source code formatting; unlike
> > asserts trailing whitespace is not itself a bug.
> 
> Isn't the solution simply to configure your text editor to remove
> trailing whitespace before you save the file?

Thats one approach.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090225/574bd943/attachment.pgp