[MERGE] Make 'ls' aware of views

Ian Clatworthy ian.clatworthy at internode.on.net
Mon Feb 23 23:24:52 GMT 2009


Eduardo O. Padoan wrote:
> On Mon, Feb 23, 2009 at 4:09 AM, Ian Clatworthy

>> 1. Take a look at bzrlib/tests/blackbox/test_filtered_view_ops.py and
>>   add one for ls.
>>
>> 2. Take a look at bzrlib/tests/workingtree_implementations/test_views.py
>>   and add a test for check_path_in_view. (It's now a public function in
>>   the API so it needs an explicit test showing it works as advertised.)
> 
> Done. Thanks for the pointers, Ian.

Hmm - the patch attached was missing these changes. Perhaps you didn't
commit them before generating the diff?

bb:resubmit

Also, it's preferable to generate a "merge directive" instead of a plain
patch so that your changes appear in log as nested revisions. To do this,

  bzr send -o ../ls-views.patch

and email that file. Plain patches are fine but merge directives are better.

Ian C.



More information about the bazaar mailing list