[MERGE] Fixing Typos in documentation (Resend)

Ben Finney bignose+hates-spam at benfinney.id.au
Sun Feb 22 23:03:08 GMT 2009


Frank Aspell <frankaspell at googlemail.com> writes:

> === modified file 'bzrlib/remote.py'
> --- bzrlib/remote.py	2009-02-21 00:05:58 +0000
> +++ bzrlib/remote.py	2009-02-22 16:54:02 +0000
> @@ -444,7 +444,7 @@
>      def abort_write_group(self, suppress_errors=False):
>          """Complete a write group on the decorated repository.
>          
> -        Smart methods peform operations in a single step so this api
> +        Smart methods perform operations in a single step so this api
>          is not really applicable except as a compatibility thunk
>          for older plugins that don't use e.g. the CommitBuilder
>          facility.
> @@ -458,7 +458,7 @@
>      def commit_write_group(self):
>          """Complete a write group on the decorated repository.
>          
> -        Smart methods peform operations in a single step so this api
> +        Smart methods perform operations in a single step so this api
>          is not really applicable except as a compatibility thunk
>          for older plugins that don't use e.g. the CommitBuilder
>          facility.
> @@ -731,7 +731,7 @@
>      def start_write_group(self):
>          """Start a write group on the decorated repository.
>          
> -        Smart methods peform operations in a single step so this api
> +        Smart methods perform operations in a single step so this api
>          is not really applicable except as a compatibility thunk
>          for older plugins that don't use e.g. the CommitBuilder
>          facility.

Best to fix the capitalisation of the initialism “API” in all these.

> === modified file 'doc/developers/planned-performance-changes.txt'
> --- doc/developers/planned-performance-changes.txt	2007-06-19 00:48:22 +0000
> +++ doc/developers/planned-performance-changes.txt	2009-02-22 16:54:02 +0000
> @@ -50,7 +50,7 @@
>     considered a cache this is not exposed in such a way that cache operations
>     like 'drop the cache' can be performed. On current disk formats the cache is
>     mandatory, but an API to manage would allow refreshing of the cache (e.g.
> -   after ghosts are filled in in baz conversions).
> +   after ghosts are filled in "in baz conversions").

This results in a sentence that now makes no sense. Why enclose these
words in quotation marks?

The sentence is correct by itself before the change. If it's unclear
(the double occurrence of “in” might be tricky to parse)I suggest
change that line to the following:

    after ghosts are filled in during baz conversions).

> === modified file 'doc/en/user-guide/specifying_revisions.txt'
> --- doc/en/user-guide/specifying_revisions.txt	2007-12-14 07:35:49 +0000
> +++ doc/en/user-guide/specifying_revisions.txt	2009-02-22 16:54:02 +0000
> @@ -93,7 +93,7 @@
>  **before**
>      ''rev'' specifies the leftmost parent of ''rev'', that is the revision
>      that appears before ''rev'' in the revision history, or the revision that
> -    was current when ''rev'' what comitted.
> +    was current when ''rev'' what committed.

Your fix is correct, but misses a false positive (“what” instead of “was”):

    was current when ''rev'' was committed.

-- 
 \                              “Holy polar ice sheet, Batman!” —Robin |
  `\                                                                   |
_o__)                                                                  |
Ben Finney




More information about the bazaar mailing list