[MERGE] fetch refactoring resend

[Robert Collins]

On Fri, 2009-02-20 at 09:10 -0600, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > Better submit location ftw.
> > 
> > 
> 
> So one thing that sticks out for me, is that you didn't change the logic
> ordering in "get_stream()".
> 
...
> This is necessary for *knit* compatibility, but not for *pack*
> compatibility. And has the major downside that it reads the inventory
> objects 2x.
> 
> Instead, what we really want is to be able to stream across the
> inventory records, and build up what we need to fetch next. (Perhaps you
> have another 'get_stream()' implementation planned?

Yes. We want a source that can be remoted as well, for streaming fetch;
small steps :).


> ^- Using "_" as a real variable seems wrong. It certainly seems like
> this *should* be:
> 
> for result in self._generate_root_texts(revs):
>   yield result

Yah, I'll fix for this next week.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090221/154462ff/attachment.pgp