[MERGE] fetch refactoring resend

Robert Collins robertc at robertcollins.net
Fri Feb 20 06:27:37 GMT 2009


On Fri, 2009-02-20 at 16:59 +1100, Andrew Bennetts wrote:
> bb:tweak
> 
> Looks good to me, just one nit:
> 
> Robert Collins wrote:
> > === modified file 'bzrlib/remote.py'
> [...]
> > +    @property
> > +    def _serializer(self):
> > +        # We should only be getting asked for the serializer for
> > +        # RemoteRepositoryFormat objects except when the RemoteRepositoryFormat
> > +        # object is a concrete instance for a RemoteRepository. In this case
> > +        # we know the creating_repo and can use it to supply the serializer.
> > +        self._creating_repo._ensure_real()
> > +        return self._creating_repo._real_repository._format._serializer
> 
> The comment doesn't quite parse for me.  I think it should read “We should not
> be getting asked ...”?

removed the word except :P

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090220/63f27bf2/attachment.pgp 


More information about the bazaar mailing list