[RFC] temporarily disable format-display after creating repositories/branches?
John Arbash Meinel
john at arbash-meinel.com
Thu Feb 19 14:55:23 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Robert Collins wrote:
> This is just a discussion point; I haven't tracked down all the info.
> With the latest network performance patches applied, init-repo completes
> its work with 4 round trips. It takes 16 to complete the command though
> - from 5 through 16 are doing:
> if not is_quiet():
> from bzrlib.info import show_bzrdir_info
> show_bzrdir_info(repo.bzrdir, verbose=0, outfile=self.outf)
> Now, eventually we need to optimise this, but it would be a lot easier
> to simply drop this from the default behaviour, with a plan to reinstate
> it later.
> Alternatively, if someone wanted to dig in an optimise these two lines
> now, I'd be delighted to leave them in-place and provide advice on how
> to add verbs to the smart server and so on.
Is "bzr init-repo bzr+ssh://" something we are really trying to
optimize? I can see optimizing "bzr push bzr+ssh://" which creates a new
repository, but the former is not really a performance critical piece of
As for me, I've come to like the display, so I'd rather not see it go.
(though I'll admit I don't like it enough to spend the time to bring it
back if it was voted off).
So IMO, I'm willing to accept the extra 11 round trips for a
non-critical command, rather than either asking anyone to spend a lot of
time optimizing it, or getting rid of a nice UI feature.
If you feel strongly, you can get rid of it, but it wouldn't be my choice.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar