[MERGE][bug #300177] Pass compression_parent as part of 'get_record_stream'
John Arbash Meinel
john at arbash-meinel.com
Mon Feb 16 17:13:30 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jelmer Vernooij wrote:
> Jelmer Vernooij has voted comment.
> Status is now: Semi-approved
> Comment:
> It would indeed be nice if this could be specific to KnitContentFactory
> rather than for all ContentFactory's, since that means no API changes
> for foreign implementations.
>
> For details, see:
> http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C498CB306.30201%40arbash-meinel.com%3E
>
> Project: Bazaar
>
>
Well, the base level ContentFactory implements "compression_parents =
None", so at least implementations that inherit from that wouldn't have
to change.
I still haven't heard a great way to actually solve this. If I make it
an API on ContentFactory then the same argument applies. It is either
that or change "insert_record_stream" to do "getattr()" logic, which
seems a bit overkill.
In essence, we need *some* way to determine if a record refers to
another record before it can be properly extracted to a fulltext. We
don't currently have that (well we do, but infer it from a list of known
types, which is a *worse* solution IMO).
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkmZnroACgkQJdeBCYSNAAPuKwCglVnDVz7NDinzFZ/XDadQ3QNz
7mwAoIJrhXgjdZRiD6jreuaSU7yJW3gg
=v5Gw
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list