[MERGE] fix #306394 (status handle non-existent files too)
Ian Clatworthy
ian.clatworthy at canonical.com
Tue Feb 10 00:36:27 GMT 2009
Ian Clatworthy wrote:
> Karl Fogel wrote:
>> + for nonexistent in nonexistents:
>> + if short:
>> + prefix = 'X '
>> + else:
>> + prefix = ' '
>> + to_file.write("%s %s\n" % (prefix, nonexistent))
>
> The calculation of prefix should probably be done outside the loop.
> In practice, this ought to happen *so* rarely that's it very minor though.
Hmmm - I've left it as is and put a comment in as to why doing it there
is fine.
> I'll make the necessary tweaks, including splitting the tests as Jelmer
> suggested, and merge.
Done and sent to PQM.
Ian C.
More information about the bazaar
mailing list