[MERGE] Consistently write to self.outf in cmd_push().

Jelmer Vernooij jelmer at samba.org
Tue Feb 3 19:06:03 GMT 2009


On Tue, Feb 03, 2009 at 12:12:22PM -0500, Aaron Bentley wrote:
> Jelmer Vernooij wrote:
> > Right now, bzr push will write status messages to to /dev/stdout when
> > it's updating an existing branch and write status messages
> > to /dev/stderr when it has created a new branch. 

> > The attached patch makes it consistently write to stdout.

> I don't think that's the right fix.  Push's main function is to update a
> branch or working tree.  All its output is therefore incidental and
> should go to stderr.

> Only command whose main purpose is to produce output (diff, status,
> etc.) should be writing to stdout.
Is there an equivalent to self.outf for stderr? I can't find any.

What about the log output displayed by bzr push -v, should that still
go to stdout ?

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://jelmer.vernstok.nl/
 19:45:28 up 32 days, 22:33,  3 users,  load average: 1.04, 1.12, 1.24



More information about the bazaar mailing list