[PATCH] 306394 fix (warning, not error, on non-existent file)

[Karl Fogel]

Robert Collins <robertc at robertcollins.net> writes:
>> removed:
>>   FILE_E
>> modified:
>>   FILE_B
>>   FILE_C
>> nonexistent:
>>   NONEXISTENT
>
> I have to say, that I think this is not very visible to users. Users of
> the UI have a tendancy to not-read-the-details.
>
> I don't think this is a good idea overall, because it is less consistent
> with commit; perhaps commit should change as well? However, as I rarely
> issue specific paths when invoking status, I won't be personally
> inconvenienced, at least until we start dealing with support requests
> from people confused by it :).
>
> I would request that:
>  - status exit with error in this case
>  - it be made _much_ more visible.

I've got it exiting with error code 3 now, which is the same error code
commit gives if invoked on files that don't exist.  (Our IRC
conversation today was helpful, as was Martin's mail
https://lists.ubuntu.com/archives/bazaar/2008q4/051045.html.)

It also prints an error at the end, after printing all the requested
statuses.

I'll submit the bundle in the more recent [MERGE] thread on this.

> After all, 'bzr st /missing/path' errors clearly and cleanly, and this
> can be thought of as just another case of a missing path :P.

Er.  Hmrmrmm :-).

-K