[MERGE] Show all merge revisions in 'commit -v' message template

[Colin D Bennett]

On Thu, 29 Jan 2009 22:37:23 +1000
Ian Clatworthy <ian.clatworthy at internode.on.net> wrote:

> In the case of status, showing just the merge tips by default was done
> because the long list of revisions, after merging from trunk into a
> feature branch in particular, scrolled the interesting information
> (i.e. what files were changed) off the screen.
> 
> I don't think the same problem exists for commit because the message
> template is loaded into an editor isn't it? In that case, I think the
> display of the merged revisions should always be the verbose form.

Sounds good to me.

> At first glance, the code looks fine. I suspect a one line patch is
> all that we want here though, i.e. just setting verbose=True on the
> call to show_tree_status(). A test would be good as well to ensure
> this doesn't regress. (As the "bug" was only introduced in this
> development version, no NEWS entry is required.)

Should I derive a simpler patch with the "one-liner" fix and an
appropriate test case (basically the 'commit -v' test I added?) and
re-submit it?

Regards,
Colin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090129/a029c1a3/attachment.pgp