[MERGE] add stop_rule to Branch.iter_merge_sorted_revisions()

John Arbash Meinel john at arbash-meinel.com
Tue Jan 27 20:04:49 GMT 2009


John Arbash Meinel has voted comment.
Status is now: Semi-approved
Comment:
So, the fact that you need to add this complexity makes me feel that the 
api isn't quite what we want.

For example, if you used an 'exclusive' range, callers could always 
convert that into an inclusive range by doing:

base=X
base_parent=get_parent_map([base])
iter_merge_revisions(start, end=base_parent)

(grab the parent of the given revision, and do an exclusive search on 
that.)

In fact, I would even consider that we may want to allow multiple stop 
revisions So that you would pass both parents of the revision.

If you feel like this is still the best way to go, then we can certainly 
do it. I'm mostly suggesting that the simplest api that can get the 
information we need is probably better.


For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C497E8EBF.3010109%40internode.on.net%3E
Project: Bazaar



More information about the bazaar mailing list