[MERGE][#321066] "bzr log -r 1.1.1..1" dotted revnos in the wrong order raises ValueError

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marius Kruger wrote:
> 2009/1/27 John Arbash Meinel <john at arbash-meinel.com
> <mailto:john at arbash-meinel.com>>
> 
>     +            self.assertTrue('revno: %s\n' % revno not in log,
>     +                'Contains unexpected revno %s' % revno)
> 
>     ^- I would find this easier to read as:
>     self.assertFalse(('revno: %s\n' % revno) in log)
> 
>     The extra parenthesis make it clear that it isn't
>     'revno: %s\n' % (revno not in log)
> 
>     Also, I think "assertFalse((x in y))" is a tiny bit clearer than
>     "assertTrue((x not in y))" but that is certainly a personal taste thing,
>     and you can do it however you like.
> 
> 
> it makes sense. done.
> 

BB:approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkl+REYACgkQJdeBCYSNAAMMWwCgm1/abUquTy+NqmBcwSV/4w5k
gHkAoI32Df4FHJEnMoOu9tSgF1In1ink
=Wzy9
-----END PGP SIGNATURE-----