[MERGE] Re: ProgressTask UserWarning branching stacked->unstacked

John Arbash Meinel john at arbash-meinel.com
Mon Jan 26 21:00:22 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This should be happening any time you push using the generic fetch code.

Martin added some code, such that if you create a nested progress bar,
and then call ".update()" on the parent, it issues the warning you saw.

And it turns out that the generic fetching code was creating a nested
progress bar that it never used.

The attached patch should prevent the warning.

John
=:->


Colin D Bennett wrote:
> When I branch from a stacked standalone tree (format 1.9) to a
> non-stacked standalone tree, I get a UserWarning:
> 
> 
> bugtest1 $ mkdir branch1
> bugtest1 $ cd branch1
> bugtest1/branch1 $ bzr init --1.9
> Created a standalone tree (format: 1.9)                                             
> bugtest1/branch1 $ echo Hello > World
> bugtest1/branch1 $ bzr add World
> added World
> bugtest1/branch1 $ bzr ci -m 'World added'
> Committing to: /home/cdb/tmp/bugtest1/branch1/                                      
> added World
> Committed revision 1.                                                               
> bugtest1/branch1 $ cd ..
> bugtest1 $ bzr branch --stacked branch1 feature1
> Created new stacked branch referring to file:///home/cdb/tmp/bugtest1/branch1/.     
> bugtest1 $ bzr branch feature1 feature1copy
> /home/cdb/bin/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(1/3, msg='fetch inventory') is not the top progress task ProgressTask(None/None, msg='')
>   (task, self._task_stack[-1]))
> /home/cdb/bin/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(2/3, msg='fetch inventory') is not the top progress task ProgressTask(None/None, msg='')
>   (task, self._task_stack[-1]))
> Branched 1 revision(s).                                                             
> 
> 
> I am using bzr.dev revision: 3959
> revid: pqm at pqm.ubuntu.com-20090126115928-bzzqlmw316iv8o3k
> 
> Regards,
> Colin

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkl+JGYACgkQJdeBCYSNAANn/ACfTpYbb03o6eL1LVEQRfjjGwMh
hSkAn3qfJMeLpX7Wvw55C4eELTb9xWyU
=D2m0
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 1.12-progress-warning.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20090126/61131915/attachment.diff 


More information about the bazaar mailing list