[MERGE] Make svn plugin import faster, mainly by deferring import of subvertpy.

Andrew Bennetts andrew.bennetts at canonical.com
Mon Jan 26 04:51:53 GMT 2009


Jelmer Vernooij wrote:
> Hi Andrew,
> 
> On Mon, 2009-01-19 at 05:10 +0100, Jelmer Vernooij wrote:
> > On Mon, 2009-01-19 at 14:10 +1100, Andrew Bennetts wrote:
> > > This patch makes bzr-svn import a bit faster.  I haven't done extensive timings,
> > > but I'm pretty sure that avoiding importing subvertpy (unless it is actually
> > > used) saves tens of milliseconds on my laptop.
> > Thanks for the patch! It looks ok, but appears to break some tests, e.g.
> > bzrlib.plugins.svn.tests.test_errors.TestConvertError
> > 
> > I don't think I'm familiar enough with lazy_import to fix this one
> > easily. Any chance you can have a look?
> This turned out to be caused by a wildcard import. I've fixed this and
> merged your patch. Thanks!

Oh, awesome.  Too easy :)

-Andrew.




More information about the bazaar mailing list