[MERGE] Re: Bug in the new progress bar

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> John Arbash Meinel wrote:
>> I'm seeing something odd with the new progress bar implementation. I
>> haven't debugged why yet, but this is what I see (snapshots at different
>> points in time).
> 
> Ditto.
> 
>> e) If it wasn't for the nesting, I think I like it. Well, that and the
>>    fact that it is pretty much broken for 'bzr co', but I think some
>>    things (like bzr pull) already were broken.
> 
> There's also a buglet with flushing the output at the end I'm seeing
> now and then. It needs a bit of polish/bug-clean-up (and getting use to)
> but I think it will turn out better overall.
> 
> Ian C.
> 

So I found the specific problem. Namely, CLIUIFactory overrides
"progress_finished()" into a no-op, when it still needs to pop the task
off the stack.

I think Martin did this accidentally when he tried to suppress the
warning about nested progress errors.

This fixes the progress bars to look correct to me.

I also had to make it so it really didn't warn about finishing the wrong
task, as the old code wasn't warning 'by accident'.

Note there are still some other oddities. Like when I just did:
$ bzr send -o ../XXXX
Using saved submit location "C:/Users/jameinel/dev/bzr/bzr.dev" to
determine what changes to submit

Bundling 1 revision(s).
[/                   ] Walking content. 0/1

For whatever reason it isn't cleaning up its progress indication.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklw3Y8ACgkQJdeBCYSNAAOX8ACfZlMhdlV51l5AcB4dzMdSbJpl
bMoAnivM4wGb/zosw5TPLJMrC7XCKPpB
=zS6N
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: progress-updates.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20090116/a75a89d8/attachment.diff