[PATCH] 306394 fix (warning, not error, on non-existent file)

John Arbash Meinel john at arbash-meinel.com
Tue Jan 13 21:04:52 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Karl Fogel wrote:
> I still need to write tests, which is why this isn't a [MERGE] request,
> but some review on the code would be good.
> 
> Attached are the bundle, and a shell script you can run to demonstrate
> the new behavior.  Below is the output of that script.  As you can see,
> "X" is the new leftmost-column character indicating nonexistence.
> Comments welcome!
> 
> -K
> 
> --------------------------------------------------------------------------
> Repository tree (format: pack-0.92)
> Location:
>   shared repository: /home/kfogel/src/bzr/bzr-repo
>   repository branch: .
> added FILE_A
> added FILE_B
> added FILE_C
> added FILE_D
> added FILE_E
> Committing to: /home/kfogel/src/bzr/bzr-repo/bzr.dev-306394/demo-306394/
> added FILE_A
> added FILE_B
> added FILE_C
> added FILE_D
> added FILE_E
> Committed revision 1.
> deleted FILE_E
> added FILE_Q
> 
> ### Try standard 'bzr status --short':
> 
>  M  FILE_B
>  M  FILE_C
> -D  FILE_E
> +N  FILE_Q
> ?   UNVERSIONED_BUT_EXISTING
> 
> ### Try 'bzr status --short NONEXISTENT ':
> 
> X   NONEXISTENT

X seems a reasonable alternative for nonexistent. Though I would also
want to make sure you thought about "bzr status" (without --short) for
how it would represent these files.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkltAfQACgkQJdeBCYSNAAO6HQCcCRzarAyPxb0Ifd++l1QII2Zj
DIwAn2Y7wxwIuRdATMm7R3FFUPeARXWs
=HgOi
-----END PGP SIGNATURE-----



More information about the bazaar mailing list