[MERGE] Support for tbzr c++ implemented shell extension

Martin Pool mbp at canonical.com
Fri Jan 9 05:20:42 GMT 2009


On 30 Dec 2008, Ian Clatworthy <ian.clatworthy at internode.on.net> wrote:
> Mark Hammond wrote:
> > On 28/12/2008 9:21 AM, John Arbash Meinel wrote:
> 
> >>> To be clear - I should resubmit the patch with only that comment
> >>> changed to get an "approve"?
> 
> >> Seems reasonable to me.
> > 
> > Attached.
> > 
> 
> From what I understand of this, it generally looks OK to me.
> Some minor tweaks/questions below.
> 
> bb: tweak

I've added a NEWS entry based on the merge proposal and fixed the typo.  

For this kind of tweak, if the person who originally proposed it, I
think it's better to just do it and merge it in; it's 
inefficient to ask the originator to resubmit it.  Or, of course, one
could say something like "I've read this and it just needs X, could
someone merge it?"

Also, I'm thinking that Mark would be fine as a core team member (even
if specialized in Windows), and one review should be enough to
merge his changes.

-- 
Martin      <http://launchpad.net/~mbp>



More information about the bazaar mailing list