[MERGE] Allow changing --[no-]trees with reconfigure (bug 145033)

Ian Clatworthy ian.clatworthy at internode.on.net
Fri Jan 9 00:58:23 GMT 2009


Matthew D. Fuller wrote:

> I expect the major bikeshed will be the naming of the options,
> "--with-trees" and "--with-no-trees".  init-repo uses --trees and
> --no-trees.  However, reconfigure already has a --tree option, and I
> fear that --trees would get lost against that too easily.  There's
> also the matter of how --trees and --no-trees would get sorted in the
> help output (far apart).  So, I'm reasonably happy with that choice.

I think your option names are fine and the overall patch is good.
I'd like one more test before accepting it though.

bb:resubmit

I think you need a test covering "reconfiguration not supported"
when used in a non-shared repo.

Please add an item to NEWS as well, mentioning the bug and
taking the credit for fixing it.

Ian C.



More information about the bazaar mailing list