[MERGE] Implement native python ssl support for https

[Ian Clatworthy]

Vincent Ladeuil wrote:
> This patch starts using the ssl module provided by python-2.6 to
> implement https support for our urllib https client.
> 
> As a first step it mainly provides an https test server and add a
> test permutation for both pycurl and urllib to exercise it
> against all our current transport tests.

Assuming the usages of openssl are correct in the create_ssls.py
tool you've written, the rest looks good to me.

bb:tweak

A NEWS entry under TESTING would be good.

> +        return sslconn, addr
> +
> +class TestingHTTPSServer(TestingHTTPSServerMixin,

Extra blank line needed between classes.

> +    # Provides usable defaults since an https server requires both a

s/since an/since a/

> +# Directory containing all ssl files, keys or certificates
> +base_dir = osutils.dirname(osutils.realpath(__file__))
> +
> +def build_path(name):

Extra blank line before function.

> +    if tests.HTTPSServerFeature.available():
> +        from bzrlib.tests import (
> +            https_server,
> +            ssl_certs,
> +            )
> +
> +        class HTTPS_pycurl_transport(PyCurlTransport):
> +
> +            def __init__(self, base, _from_transport=None):
> +                super(HTTPS_pycurl_transport, self).__init__(base,
> +                                                             _from_transport)
> +                self.cabundle = str(ssl_certs.build_path('ca.crt'))
> +
> +        permutations.append((HTTPS_pycurl_transport,
> +                             https_server.HTTPSServer_PyCurl))

> +    if tests.HTTPSServerFeature.available():
> +        from bzrlib.tests import https_server
> +        permutations.append((HttpTransport_urllib,
> +                             https_server.HTTPSServer_urllib))

Why did you not declare a HTTPS_urllib_transport like you did
a HTTP_pycurl_transport?

Ian C.