[MERGE] Clean up pull -v

Ian Clatworthy ian.clatworthy at internode.on.net
Tue Jan 6 08:05:40 GMT 2009


Aaron Bentley wrote:
> Here's a slightly evolved version of my patch.

All looks fine to me bar one spelling mistake.

bb:tweak

> +def get_history_change(old_revision_id, new_revision_id, repository):
> +    """Calculate the uncommon lefthand history between two revisions.
> +
> +    :param old_revision_id: The original revision id.
> +    :param new_revision_id: The new revision id.
> +    :param repository: The repository to use for the calcualtion.

calculation spelling.

Good job on the tests and thanks for removing yet another O(history)
wart.

I agree with Vincent that it would be nice if show_branch_change()
took a log format/formatter parameter but it can come later when
it's required.

Ian C.



More information about the bazaar mailing list