[MERGE] Add ForeignBranch

Jelmer Vernooij jelmer at samba.org
Sat Dec 27 23:51:27 GMT 2008

Hi Aaron,

Am Samstag, den 27.12.2008, 18:37 -0500 schrieb Aaron Bentley:
> Jelmer Vernooij wrote:
> > The attached patch adds a simple ForeignBranch class, as it is used at
> > the moment as base class for the Branch classes in bzr-svn and bzr-git.
> Hi, I don't want to be a blocker on this, but could you explain it a bit
> more?
> What's the "mapping" ivar?

The mapping ivar is a instance of "bzrlib.foreign.VcsMapping", or a
class derived from it. It is the mapping that will be used to generate
bzr revisions from foreign VCS metadata. In the case of Subversion,
there have historically been four different subclasses of VcsMapping,
each added in a different major release of bzr-svn, and each improving
the way the mapping between bzr and svn is done.

> Why are you defining dpush here?  Are you going to test whether branches
> are ForeignBranches and then call dpush if they are?
dpush is a separate bzr subcommand that is similar to "bzr push" but
will not try to do any roundtripping (so it may lose some data, if it
can not be represented in the foreign VCS it is pushing to). This also
has the consequence that it does not preserve the identity of the
revisions it pushes, since the changes that end up in the remote VCS may
not be exactly the same as in the local branch, thus violating one of
the primary invariants of push (which is why I think it should be a
different command).

Examples of the sort of metadata that may not be pushed include (but are
not limited to).

I've got a separate patch that adds the dpush command, for which I am
adding tests at the moment and then hope to submit later. 



Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081228/47a650c5/attachment.pgp 

More information about the bazaar mailing list