[MERGE] Fix for 306394: warning, not error, on non-existent file.

Jelmer Vernooij jelmer at samba.org
Tue Dec 23 23:39:47 GMT 2008


Am Dienstag, den 23.12.2008, 17:22 -0500 schrieb Karl Fogel:
> Attached is a fix for https://bugs.edge.launchpad.net/bzr/+bug/306394:
> 
>    "bzr status should not ignore all other command line arguments when
>     passed a non-existent file"
> 
> My first time posting a bundle, so please let me know what I got
> wrong :-).  Thanks to jam in IRC for help with how to bundle.
=== modified file 'bzrlib/status.py'
--- bzrlib/status.py    2008-10-01 05:40:45 +0000
+++ bzrlib/status.py    2008-12-17 16:28:06 +0000
@@ -28,6 +28,7 @@
 from bzrlib.osutils import is_inside_any
 from bzrlib.symbol_versioning import (deprecated_function,
         )
+import warnings
^^^ This import should be higher up in the file, since it is not an
import from bzrlib.

Are you really sure you need this module though? It seems like you don't
actually use anything from it.

I think it would make sense to still exit with a non-zero exit code if
one of the files specified was not found. Is there a bzr policy wrt the
exit code of partially succeeding/partially failing commands?

bb:comment

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081224/c389a863/attachment-0001.pgp 


More information about the bazaar mailing list