[MERGE] 1.12-preview formats

[Ian Clatworthy]

Aaron Bentley wrote:

> Performance is not the reason we do it.  We do it so that
> 1. New formats are not dependant on older ones.  This means older
> formats can be decomissioned as needed.
> 
> 2. We care more about newer formats, especially as times goes on and
> they become default formats.  This keeps their code consolidated in one
> place.
> 
> It's also worth bearing in mind the fact that none of our working tree
> formats were introduced since we changed our procedures to make older
> formats subclass newer ones.

All good points. At poolie's suggestion, I've introduced some base
classes in workingtree_4.py and made WorkingTree4/WorkingTreeFormat4 and
WorkingTree5/WorkingTreeFormat5 both subclass these. The updated patch
is attached.

I searched out each of the places where WorkingTreeFormat4 was used and
I think I've got all the *necessary* bits of code changed. Let me know
please if other places ought to be changed as well, e.g. references to
_matching_from_tree_format/_matching_to_tree_format for the inter-tree
tests.

Ian C.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.12-preview-formats-2.patch
Type: text/x-diff
Size: 25796 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081222/75f00bdb/attachment-0001.bin