[MERGE] Less bazaar coding style regressions.
John Arbash Meinel
john at arbash-meinel.com
Fri Dec 19 18:29:01 GMT 2008
John Arbash Meinel has voted tweak.
Status is now: Conditionally approved
Comment:
=== modified file 'bzrlib/tests/test_source.py'
--- bzrlib/tests/test_source.py 2008-08-11 02:04:00 +0000
+++ bzrlib/tests/test_source.py 2008-12-13 12:32:57 +0000
@@ -25,13 +25,17 @@
import os
import parser
import re
+from StringIO import StringIO
^- I'm pretty sure we want "from cStringIO import StringIO", do you know
why you would have used the other form?
Otherwise I'm pretty sure Martin approved the rest of it, so I'm happy
to go ahead and submit this.
As mentioned, Martin has declared that we can go ahead and cleanup the
whole source tree for trailing whitespace and go ahead and merge that.
Last I checked, there were a couple places in the test suite that needed
a trailing whitespace because it used an raw string, but I'm pretty sure
that can be changed to escaping the characters. "\x20" being a plain
space. I'm in agreement with him (rip the bandaid off).
In the meantime, this patch still helps.
For details, see:
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C418c22640812130437k59ecab49g6b49b9a8248117bb%40mail.gmail.com%3E
Project: Bazaar
More information about the bazaar
mailing list