[MERGE] AtomicFile names are now not invariant-per-process which stops multiple transactions on the same file breaking under unknown conditions on Windows CIFS shares

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adrian Wilkins wrote:
> John Arbash Meinel wrote:
>> Adrian Wilkins wrote:
>>
>>> https://bugs.launchpad.net/bzr/+bug/304023
>>
>> This seems fine, though it seems like it would be good to understand why
>> we are trying to modify the same file 2x in a given action.
>>
>> As it sounds like we are creating 2 "AtomicFile" objects for the
>> pack-names file, which is a bit iffy.
>>
> 
> This seems to agree with the behaviour I was seeing. The logs attached
> to one of the bug comments show the file activity for both failing and
> successful cases, and for the post-patch case, which should show the
> multiple use of AtomicFile for last-revision file. The logs are for
> 
> bzr branch <network branch one> <new branch in same no-trees repo>


I went ahead and submitted your change, since it is fairly small and
works around the bug. Further, I don't think I'm going to have time to
debug the actual problem anyway.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklL5ioACgkQJdeBCYSNAAOwxQCfaJgEvHmBrwOdDYbcPsjcL7Id
XLIAoJaNa7g8tBapjmcm7jQODAK3lr7G
=+eBE
-----END PGP SIGNATURE-----