[MERGE] [bug #256612] Don't require "user@" in HTTP(S) URLs that need auth

[Marius Kruger]

(sorry previous mail sent prematurely for some reason, tab-enter in web mail
sends mail?!)

2008/12/17 Marius Kruger <amanic at gmail.com>

> Hi,
>
> first off, thanks for submitting this. About 2 seconds after I hit this
> bug,
> I read your mail. good timing.
>
> * you should put your name in the NEWS, so that everybody can see
>   who fixed/broke it :)  (see the other news entries)
>
> * there is about 8 test failures which should be fixed eg.
> FAIL:
> test_http.TestAuth.test_no_user(urllib,HTTP/1.0,basic)
>
>     not
> equal:
>
> a =
> 1
>
> b = 2
>
> * why did you remove the part that obtains the user name from the request?
>
>>          if user is None:
>> -            user = auth.get_user(auth['protocol'], auth['host'],
>> +            user = auth_conf.get_user(auth['protocol'], auth['host'],
>>                                   port=auth['port'], path=auth['path'],
>>                                   realm=realm)
>
>
 I think it should rather be like:

         if user is None:
              user = auth.get_user(auth['protocol'], auth['host'],
                                  port=auth['port'], path=auth['path'],
                                  realm=realm)
              if user is None:
                    user = auth_conf.get_user(auth['protocol'],
auth['host'],
                                  port=auth['port'], path=auth['path'],
                                  realm=realm

* It would be great if you can add a test for the new behaviour.

BB:resubmit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20081217/9a2934db/attachment.htm