[MERGE] Support for tbzr c++ implemented shell extension

[Mark Hammond]

> I think it could be as simple as having a known function to call with
> given arguments.
> So in bzr's setup.py you have
> 
> from tbzrlib import setup_config
> setup_config.configure_for_setup(current_state...)

For Tortoise, integrating with the .iss.cog file will also be a challenge.

> Which could probably be re-used in tbzr's setup.py (if it had one).

It does - but its setup.py doesn't have anything py2exe related.

> >> +    # py2exe may find references to part of the plugin (eg, the tests)
> >> +    # so we tell py2exe to leave the plugins out of the .zip file
...

> > We ship plugins as normal files on the file-system - however, the
> build process can cause *some* of these plugin files to end up in
> library.zip.  Thus, I saw (eg) "plugins/svn/test" in library.zip, and
> then saw import errors related to that as the rest of the svn plugin
> wasn't.  The above change avoids any part of the plugins ending up in
> library.zip file.
> >
> 
> K. I think I'd like to have that statement verbatim here. To explain
> the difference.

To be clear - you want the 2 comment lines above that say we are excluding the plugins from library.zip replaced with the 6 lines above, as they stand, which says we are excluding the plugins from library.zip?

> > See above - I think a single installer is the simplest and easiest,
> and it detects a 32bit OS and doesn't attempt to install the 64bit
> shell extension.  The downside though is that the 32bit installer is
> bigger than it needs to be.
> >
> 
> But only for the single .dll, right? Does that add any appreciable
> size?

The 64bit DLL itself is 260kb, but we also need to ship a 64bit version of tortoise-overlays at 227kb.  I expect our DLL will compress well, but the MSI probably already is compressed.

> PS> BB:tweak ish, though BB won't let me vote this far down in the
> thread.

To be clear - I should resubmit the patch with only that comment changed to get an "approve"?

Cheers,

Mark