[MERGE] Fix #87179 by using the short status format when the short format is used for log.

John Arbash Meinel john at arbash-meinel.com
Fri Dec 5 13:22:39 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


...

>     aaron> I happen to like both, but aside from the name, they
>     aaron> are pretty different.
>     >> 
>     >> As commented on the bug page, what about using the short form
>     >> with -v and the long one with -vv ?
> 
>     aaron> That would be okay with me.  I think at one point we
>     aaron> were going to make log -vv show diffs, but we later
>     aaron> decided to have a --show-diffs option instead.
> 
> The attached patch does that.
> 
>     Vincent
> 
> 

To be clear, it implements "-vv" not "--show-diffs".

I'm a little bit hesitant to change the default behavior. If people are
running scripts that parse "bzr log -v" those are going to break.

At a minimum, we need to have it clearly mentioned in NEWS, etc.

*I* don't use 'bzr log -v' so I don't really feel competent to say how
much of an impact this will have.

I would have just gone with "log --short -v" uses the short form for
status and not worried about it as much. I *do* realize they are
orthogonal. I've also wanted "bzr log --long --no-merges" before, so
having --long/--short control that option is a bit much as well.

So...

1) Having a way to get short status is good
2) Breaking compatibility is bad
3) Punning the log formatting with the extra options isn't great. We are
   already doing it, but may not want to continue the process.

So I'm okay with your patch, but not quite enough to approve it. I would
prefer if other people would vote in with how much they are concerned
about compatibility, etc.

John
=:->

BB:comment
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk5Kx8ACgkQJdeBCYSNAAM/bACfWV9bXrETXJk9DYwIgslQ1Cfr
U8UAnjaPelFeVw8QnKb3ZFp54M5OurLZ
=4Guf
-----END PGP SIGNATURE-----



More information about the bazaar mailing list