[MERGE][#299313] --local commits are accessing the network

[Marius Kruger]

2008/11/28 Robert Collins <robertc at robertcollins.net>

> On Mon, 2008-11-24 at 23:18 -0500, Jelmer Vernooij wrote:
> > This should wait for 1.10 since it breaks the API. _get_nick() should
> > probably become public (in other words, be renamed to get_nick).
>
> Its a regression as it stands. I don't think _get_nick -> get_nick makes
> sense: implementors of branches have to offer methods that library
> clients don't use; making it public is a silly way to signal 'may have
> to override'.


I dont quite follow Robert here, but if _get_nick -> get_nick is not deemed
necessary,
I won't be perusing it unless somebody can motivate for it.

If there are more tests or other related things needed, let me know.

regards
marius
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20081128/3edb9a08/attachment.htm