[MERGE][bug #300289] Avoid extracting revision texts
Andrew Bennetts
andrew.bennetts at canonical.com
Wed Nov 26 06:09:39 GMT 2008
Andrew Bennetts has voted tweak.
Status is now: Conditionally approved
Comment:
Interesting that you don't use BranchBuilder... I guess for consistency
with the nearby tests?
I think there's a comment in insert_record_stream in knit.py that should
be updated:
# Not a fulltext, and not suitable for direct insertion
as a
# delta, either because it's not the right format, or
because
# it depends on a base only present in the fallback
kvfs.
The other reason a non-fulltext record might not be insertable is
because deltas aren't permitted in this versioned file, i.e.
self._max_delta_chain is 0. The code appears to do the right thing, as
you state in your explanation of the patch, but the comments in the code
don't mention this case.
Otherwise this seems fine.
For details, see:
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C492CC6D0.7040707%40arbash-meinel.com%3E
Project: Bazaar
More information about the bazaar
mailing list