[MERGE/RFC] Let _format_version_tuple accept alphas/betas/RCs with 0 sub-releases
John Arbash Meinel
john at arbash-meinel.com
Mon Nov 24 21:22:56 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Matt Nordhoff wrote:
> Someone in #bzr can't run "bzr version" because his/her sys.version_info
> looks like this:
>
> (2, 5, 2, 'alpha', 0)
>
> which is explicitly refused by _format_version_tuple:
>
>> This also checks that the version is reasonable: the sub-release must be
>> zero for final releases, and non-zero for alpha, beta and preview.
>
> Since Python.org -- or at least some distro packager or something --
> uses version numbers like that, I think it should be changed.
>
> If this is rejected, bzrlib.trace.report_bug() and
> bzrlib.version.show_version() (and any other users) should at least be
> changed to handle this more gracefully.
>
This seems reasonable to me.
I wonder if while we are at it we should turn the variables back into
regular variables instead of __*.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkkrGzAACgkQJdeBCYSNAAPhwwCfSzZZir7fOxcxLUHD6CfEhZ7J
ZKcAoIu1vi66JmoiauKLwFA71pMSJsiY
=+5kw
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list