[MERGE/RFC] Let _format_version_tuple accept alphas/betas/RCs with 0 sub-releases

Matt Nordhoff mnordhoff at mattnordhoff.com
Sun Nov 23 14:42:23 GMT 2008


Someone in #bzr can't run "bzr version" because his/her sys.version_info
looks like this:

(2, 5, 2, 'alpha', 0)

which is explicitly refused by _format_version_tuple:

>     This also checks that the version is reasonable: the sub-release must be
>     zero for final releases, and non-zero for alpha, beta and preview.

Since Python.org -- or at least some distro packager or something --
uses version numbers like that, I think it should be changed.

If this is rejected, bzrlib.trace.report_bug() and
bzrlib.version.show_version() (and any other users) should at least be
changed to handle this more gracefully.
-- 

Yay useless GPG signatures
-------------- next part --------------
A non-text attachment was scrubbed...
Name: format-alpha-0-1.patch
Type: text/x-diff
Size: 2827 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081123/2297dbaf/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081123/2297dbaf/attachment.pgp 


More information about the bazaar mailing list