[merge][#288751] avoid creating text deltas spanning repository stacks

John Arbash Meinel john at arbash-meinel.com
Wed Nov 19 14:35:32 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On Tue, Nov 18, 2008 at 10:07 AM, John Arbash Meinel
> <john at arbash-meinel.com> wrote:
> 
>> I'm not particularly fond of 'has_key()' though I can agree that having
>> all callers have to repeat the "key in get_parent_map([key])" is not
>> particularly pleasant either.
> 
> Can you expand on what you do or don't like here?

Just that if you are checking things one-by-one it is a sign that our
algorithm is probably wrong. I think we should merge your patch because
we have a hole in our current code that needs filling. Your method isn't
"optimal" but it does close a critical bug in stacked repositories.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkkJDQACgkQJdeBCYSNAAO5dQCfa8r+7F8FPuAxV8fZdPtxsS0e
mXQAnimKFTPVew4lqQ2xMxN6VlZHSpvf
=pfM/
-----END PGP SIGNATURE-----



More information about the bazaar mailing list