small change in python-compat.h (for win32)

Alexander Belchenko bialix at ukr.net
Wed Nov 19 14:19:34 GMT 2008


dirstate_helpers extension linked with winsock2 dll on windows.

if sys.platform == 'win32':
     add_pyrex_extension('bzrlib._dirstate_helpers_c',
                         libraries=['Ws2_32'])

But python-compat.h uses header from winsock1 library.
It does not harm actually, but IMO there should be consistency.

Here is proposed small one-line change:

--- bzrlib/python-compat.h 2008-10-21 15:53:56 +0000
+++ bzrlib/python-compat.h 2008-11-19 14:08:04 +0000
@@ -42,7 +42,7 @@
      #include <windows.h>

      /* Needed for htonl */
-    #include "Winsock.h"
+    #include "Winsock2.h"

      /* sys/stat.h doesn't have any of these macro definitions for MSVC, so
       * we'll define whatever is missing that we actually use.




More information about the bazaar mailing list