[MERGE][#299313] --local commits are accessing the network

[Alexander Belchenko]

Marius Kruger пишет:
> hi
> 
> 2008/11/19 Alexander Belchenko <bialix at ukr.net <mailto:bialix at ukr.net>>
> 
>     Marius Kruger пишет:
> 
>     === modified file 'bzrlib/branch.py'
>     --- bzrlib/branch.py    2008-11-15 22:12:26 +0000
>     +++ bzrlib/branch.py    2008-11-18 21:50:10 +0000
>     @@ -148,9 +148,10 @@
>         def get_config(self):
>             return BranchConfig(self)
> 
>     -    def _get_nick(self, possible_transports=None):
>     +    def _get_nick(self, local=False, possible_transports=None):
> 
>     Usually new args appended to the end of arg list to reduce errors.
> 
> 
> I know, but since
> 1) I introduced possible_transports very recently
> 2) it is in a protected method

Python has no protected methods.

> 3) it is used exactly once
> 4) for some reason I thought possible_transports could be removed when 
> making the masterbranch-authentication happen after obtaining the 
> massage again. But thinking about it again, I don't think that would be 
> possible.
> 
> So I can change it for you if you insist.

I don't care but Jelmer has objections.